Bugs - 1.23

Back in affirmative action.

Moderator: Moderators

Bugs - 1.23

Postby Cassiel » Mon Jun 14, 2010 2:46 pm

Thanks to everyone for your reports. An update is now available.


How to report a bug:

1. Make sure it's actually a bug and not you just misunderstanding what's going on.

2. Reproduce the bug in as few steps as possible and post these steps.

3. Provide a replay of the bug using the steps you've posted.
User avatar
Cassiel
 
Posts: 5087
Joined: Wed May 31, 2006 2:12 pm

Re: Bugs - 1.23

Postby Merlin » Mon Jun 14, 2010 5:40 pm

Unfortunately there are still fatal errors. I haven't found out the steps to reproduce them.

http://www.mediafire.com/?dmnqnlzqejz

The first game went off flawlessly. Let's hope these are rare events. At least until someone figures out the steps to replicate the crash.

edit: Another game ended after 8 minutes with several people crashing. http://www.mediafire.com/?mj5koxyznyw
edit2: Again, at the end. :( http://www.mediafire.com/?noyzyylygrg
User avatar
Merlin
 
Posts: 1530
Joined: Sun Jul 02, 2006 9:18 pm
Location: YUL

Re: Bugs - 1.23

Postby Merlin » Mon Jun 14, 2010 8:30 pm

I did a quick review of the 8 minute replay (because it's 8 minutes long).

The crash happens at exactly 6:48.
Pirate casts Blood Bath around 6:44.
Inq casts Shotgun around 6:45.

No one else casts around this time frame as far as I can tell. Pretty disappointing.
User avatar
Merlin
 
Posts: 1530
Joined: Sun Jul 02, 2006 9:18 pm
Location: YUL

Re: Bugs - 1.23

Postby theboogleman » Mon Jun 14, 2010 10:13 pm

The thing with fatals is that whatever caused it is hard to see in a replay. If I cast a move which causes a fatal it will fatal when I click not when move finishes(mostly).
theboogleman
 
Posts: 2390
Joined: Mon Jul 10, 2006 2:39 am

Re: Bugs - 1.23

Postby Cassiel » Mon Jun 14, 2010 10:45 pm

I looked at all the replays but only one of them crashed for me. Didn't see anything that should be causing problems either.

Try and see if there's an active hero all the crashes have in common. Heroes sitting in base doing nothing most likely aren't the cause, so focus on who's actually out fighting and using abilities and stuff.

theboogleman wrote:The thing with fatals is that whatever caused it is hard to see in a replay. If I cast a move which causes a fatal it will fatal when I click not when move finishes(mostly).

If that happened it was just a coincidence. Just ordering a hero to use an ability isn't going to cause a crash.
User avatar
Cassiel
 
Posts: 5087
Joined: Wed May 31, 2006 2:12 pm

Re: Bugs - 1.23

Postby Cassiel » Tue Jun 15, 2010 1:36 pm

Any more crashes?
User avatar
Cassiel
 
Posts: 5087
Joined: Wed May 31, 2006 2:12 pm

Re: Bugs - 1.23

Postby theboogleman » Tue Jun 15, 2010 2:20 pm

Played a full game last night without crashes, 6v6. For some reason I think it's a timming related one, ie several things firing at once causing a crash.
theboogleman
 
Posts: 2390
Joined: Mon Jul 10, 2006 2:39 am

Re: Bugs - 1.23

Postby Merlin » Tue Jun 15, 2010 2:30 pm

I agree. That theory explains the why there's such variation in these crashes. Some games are fine, some have one or two people crash, and some have five or six. Interestingly, I haven't seen a 1.23 game yet where EVERYONE crashes.

Only one person crashed after the replays I posted last night.

It isn't a confirmed crash, because the bot log only says "[TCPSOCKET] error (recv) - ECONNABORTED. <Player> has lost the connection (connection error - ECONNABORTED)". It could also be that his internet went dead or something.

10 games of 1.23 have been played on my bot since release and 3 or 4 of those had people crashing in them. Like I said, some were one or two people, while others were more.

I'll post any replays of games where people crash if you think it'll be useful.
User avatar
Merlin
 
Posts: 1530
Joined: Sun Jul 02, 2006 9:18 pm
Location: YUL

Re: Bugs - 1.23

Postby Cassiel » Tue Jun 15, 2010 3:50 pm

It shouldn't be possible for only some of the players to crash unless it's a Mac-related issue we didn't see before because so few Mac users were playing. Otherwise the cause of the crash would have to be in a local block, and we don't have anything that could do that.

What kind of bot is it? You also had a crash in your first game of 1.21, but after that nobody ever reported another one.
User avatar
Cassiel
 
Posts: 5087
Joined: Wed May 31, 2006 2:12 pm

Re: Bugs - 1.23

Postby Merlin » Tue Jun 15, 2010 3:57 pm

The same kind as yours, Ghost++.

I actually experienced two more games where everyone crashed after that first one, but this was out of over 40 games, and I didn't see any triggers in the replays, so I never bothered to report. I can look through the log to figure out which ones they were if you want to see the replays.
User avatar
Merlin
 
Posts: 1530
Joined: Sun Jul 02, 2006 9:18 pm
Location: YUL

Re: Bugs - 1.23

Postby Zeuter » Tue Jun 15, 2010 4:17 pm

Found a bug with Emissary.

At some point I decided to cheese the main, Jean comes over and flares me and the trees (not treants) next to me. Trees are destroyed, I cheese there again a few minutes later and teleport into the area where trees were destroyed. Collission gets all funky and some treants get stuck up in the air. It was as if the trees were still there collission-wise, even though they were destroyed visually. The tornado also persisted for the rest of the game.

Replay: 31 minutes in trees are cleared, 33:30 is when I get stuck.

http://www.mediafire.com/?gcw2yt3n4tn
simply
it is enough to
your task is simple;
just
all you need is to
User avatar
Zeuter
 
Posts: 3746
Joined: Tue Jul 04, 2006 11:07 am
Location: オランダ

Re: Bugs - 1.23

Postby Merlin » Tue Jun 15, 2010 4:56 pm

Got another very short game where 4 or 5 people crashed.

http://www.mediafire.com/?ujkv2yyezdj

edit: Here's one of me plus one other person crashing at around 27 minutes.

http://www.mediafire.com/?xcj2zmmhdjw
User avatar
Merlin
 
Posts: 1530
Joined: Sun Jul 02, 2006 9:18 pm
Location: YUL

Re: Bugs - 1.23

Postby Cassiel » Tue Jun 15, 2010 5:55 pm

Merlin wrote:I can look through the log to figure out which ones they were if you want to see the replays.

It would be better to have other people looking through them to see what the games that crash have in common. I don't have time to do it all myself.
User avatar
Cassiel
 
Posts: 5087
Joined: Wed May 31, 2006 2:12 pm

Re: Bugs - 1.23

Postby theboogleman » Tue Jun 15, 2010 11:13 pm

Fatal again when I play with merlin. I was br and he was jean in a 5v5.

When it fataled i was running away and so was he, neither of us was casting anything or really doing anything besides clicking. That can pretty much rule out jean and br,
theboogleman
 
Posts: 2390
Joined: Mon Jul 10, 2006 2:39 am

Re: Bugs - 1.23

Postby Merlin » Tue Jun 15, 2010 11:21 pm

Here is that replay: http://www.mediafire.com/?mzmg4j0joxr

It's only a few minutes long.
User avatar
Merlin
 
Posts: 1530
Joined: Sun Jul 02, 2006 9:18 pm
Location: YUL

Re: Bugs - 1.23

Postby Cassiel » Wed Jun 16, 2010 1:02 am

Merlin wrote:edit: Here's one of me plus one other person crashing at around 27 minutes.

http://www.mediafire.com/?xcj2zmmhdjw

Shit, I thought you were saying there were only 2 players in the game. That would've made this easier to figure out. I really wish Grimoire and war3err still worked.
User avatar
Cassiel
 
Posts: 5087
Joined: Wed May 31, 2006 2:12 pm

Re: Bugs - 1.23

Postby Mengde » Wed Jun 16, 2010 4:31 pm

Turkey, Merlin and I just found a pretty big fucking bug that might explain a lot of the crashing. If you spam Bloodbath like crazy, people fatal-error out of the game. All you need to do to reproduce this is get into a game with at least one other person on BNet, get even the tiniest bit of blood, and pound B like it's your redheaded stepchild and you came back drunk from the factory.
I know the pieces fit, 'cause I watched them tumble down.
No fault, none to blame; it doesn't mean I don't desire
To point the finger, blame the other, watch the temple topple over
To bring the pieces back together, rediscover communication.
User avatar
Mengde
 
Posts: 1254
Joined: Mon Jul 03, 2006 12:00 am
Location: Pimping Lair. Status: Super cereal.

Re: Bugs - 1.23

Postby Cassiel » Wed Jun 16, 2010 4:37 pm

I thought it might be multiple heroes using Blood Bath simultaneously, but when I tested it no dice. I never tried mashing though. So this only happens with 2+ players?

Edit: Nope, it can crash in single-player offline.
User avatar
Cassiel
 
Posts: 5087
Joined: Wed May 31, 2006 2:12 pm

Re: Bugs - 1.23

Postby Mengde » Wed Jun 16, 2010 4:38 pm

We accidentally did it in a 5v5, then retested in a 2v1, then retested again in a 1v1 with the same results. The 1v1 also revealed one person spamming can fatal-error both people out. It would have been a 2v1 but I fatal-errored out on the loading screen. (I didn't crash during the 2v1; delayed reaction much?)

EDIT: Tested an older version, 1.21. Bug exists there as well.

EDIT: 1.19 as well.
I know the pieces fit, 'cause I watched them tumble down.
No fault, none to blame; it doesn't mean I don't desire
To point the finger, blame the other, watch the temple topple over
To bring the pieces back together, rediscover communication.
User avatar
Mengde
 
Posts: 1254
Joined: Mon Jul 03, 2006 12:00 am
Location: Pimping Lair. Status: Super cereal.

Re: Bugs - 1.23

Postby Cassiel » Wed Jun 16, 2010 4:47 pm

It's linked to my UnitHasBuffOfType function. I don't know what the actual problem is yet, but in this case that's where it's coming from.

edit: Actually no it's not. This is quite strange.
User avatar
Cassiel
 
Posts: 5087
Joined: Wed May 31, 2006 2:12 pm

Re: Bugs - 1.23

Postby Mengde » Wed Jun 16, 2010 4:50 pm

I know it's inelegant, but as a temp fix maybe just disable the ability while the Blood Bath buff is active? Or just for a few seconds after casting so pubs won't pound it? I can't read JASS so I'm afraid I'm not super helpful.
I know the pieces fit, 'cause I watched them tumble down.
No fault, none to blame; it doesn't mean I don't desire
To point the finger, blame the other, watch the temple topple over
To bring the pieces back together, rediscover communication.
User avatar
Mengde
 
Posts: 1254
Joined: Mon Jul 03, 2006 12:00 am
Location: Pimping Lair. Status: Super cereal.

Re: Bugs - 1.23

Postby theboogleman » Wed Jun 16, 2010 4:52 pm

Does it bug if you have 6 heroes and they all blood bath at the same time or only when 1 hero spams it?
theboogleman
 
Posts: 2390
Joined: Mon Jul 10, 2006 2:39 am

Re: Bugs - 1.23

Postby Mengde » Wed Jun 16, 2010 4:54 pm

I got it to crash by tornadoing up to the keep, hitting it once or twice, then pounding B. And Cass got it to crash in single-player, so clearly it's not a multiple-heroes issue.
I know the pieces fit, 'cause I watched them tumble down.
No fault, none to blame; it doesn't mean I don't desire
To point the finger, blame the other, watch the temple topple over
To bring the pieces back together, rediscover communication.
User avatar
Mengde
 
Posts: 1254
Joined: Mon Jul 03, 2006 12:00 am
Location: Pimping Lair. Status: Super cereal.

Re: Bugs - 1.23

Postby theboogleman » Wed Jun 16, 2010 5:14 pm

Er just cause you can repoduce it that way doesn't mean you know the exact detail of why it crashes. I can test it when I get home anyway.
theboogleman
 
Posts: 2390
Joined: Mon Jul 10, 2006 2:39 am

Re: Bugs - 1.23

Postby Cassiel » Wed Jun 16, 2010 9:39 pm

Mengde wrote:I know it's inelegant, but as a temp fix maybe just disable the ability while the Blood Bath buff is active? Or just for a few seconds after casting so pubs won't pound it? I can't read JASS so I'm afraid I'm not super helpful.

I'm going to give it a cooldown for now, but I still need to figure out what the actual problem is. It could pop up elsewhere.
User avatar
Cassiel
 
Posts: 5087
Joined: Wed May 31, 2006 2:12 pm

Next

Return to Tides of Blood

Who is online

Users browsing this forum: No registered users and 1 guest

cron